[lldb] Use system c++ lib for LLDB STL tests #112598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroomega
changed the title
Member
|
@llvm/pr-subscribers-lldb Author: Haowei (zeroomega) ChangesThis change partially reverts #112357 to avoid test failures on machines which do not have gcc installed. Full diff: https://github.com/llvm/llvm-project/pull/112598.diff 1 Files Affected:
diff --git a/lldb/test/API/lang/cpp/stl/Makefile b/lldb/test/API/lang/cpp/stl/Makefile
index 4408691f01b701..8534fa9b00209e 100644
--- a/lldb/test/API/lang/cpp/stl/Makefile
+++ b/lldb/test/API/lang/cpp/stl/Makefile
@@ -1,9 +1,5 @@
CXX_SOURCES := main.cpp
-ifneq ($(OS),Darwin)
- USE_LIBSTDCPP := 1
-else
- USE_SYSTEM_STDLIB := 1
-endif
+USE_SYSTEM_STDLIB := 1
include Makefile.rules
|
Michael137
reviewed
Oct 16, 2024
Member
Michael137
left a comment
Michael137
left a comment
There was a problem hiding this comment.
I believe we need to just remove all the USE_ variables. The PR that broke your bots was itself motivated by a breakage due to USE_SYSTEM_STDLIB
This change partially reverts llvm#112357 to avoid LLDB STL test failures on machines which do not have gcc installed.
Contributor
Author
Done. |
Contributor
Author
|
The patch passed all presubmit tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change partially reverts #112357 to avoid test failures on machines which do not have gcc installed.
Test run: https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci.shadow/lldb-linux-x64/b8733897350805827393/overview